Ongoing example: functional, style.

As far as I know, focusing on any aspect of the code is fair game in a review. Do we want to allow such specialised-duplicates and request reviewers to answer in the appropriate one?

share

1 Answer 1

In my opinion, no. A key element of asking for a code review is asking "what is most wrong about this code?". If reviewers tend to focus on a specific aspect, it likely means that this aspect stands out more than the rest. Style does tend to do this simply due to its nature, but accepting the style criticisms, correcting where deemed justified, and then reposting with (significantly) updated code seems like a better idea than splitting the same question in two.

share

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .