I've created an opensource library wrapping some JDBC functions. I'm not satisfied with JUnit tests, and I would like it to be peer reviewed. The code is not so much and it shouldn't be reviewed line by line, just a general look by someone else would be really helpful to me. But it is too much to be copy-pasted on a question.
There are no specific portions of code to be reviewed, I'm looking for a general opinion, also to verify the fitness for use and identify gaps. I'm looking for constructive criticisms.

Is this the correct site or this is just for posting large portions of code you want others to inspect for errors?

share
    
This question+answer is a gem! –  Mat's Mug Oct 9 '13 at 1:44
add comment

1 Answer 1

up vote 17 down vote accepted

There are no specific portions of code to be reviewed, I'm looking for a general opinion, also to verify the fitness for use and identify gaps.

If that's the case, I don't think you're going to have much luck. What we do on this site is review specific pieces of code (preferably fairly small pieces). Tom Gilb and Dorothy Graham, in their book Software Inspection, recommend reviewing at most a few hundred lines at a time: more than that and inspection becomes onerous and defects are missed.

You could try posting a representative subset of your code: a function or a class, perhaps. It's possible that you'll get useful comments that you can then apply to the whole program.

share
    
I see... thank you! –  gd1 Feb 20 '13 at 18:49
add comment

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .