Questions tagged [code-ownership]

The tag has no usage guidance.

Filter by
Sorted by
Tagged with
0 votes
1 answer
30 views

Is it inappropriate to ask for code reviews on github pull requests?

I was wondering if there's a way to get code reviews on github. Although I think I know the answer to this question I want to double check. There's a question open which is about asking a review of a ...
user8469759's user avatar
4 votes
0 answers
342 views

How much modification is needed to be considered authoring the code?

In C++ PEXT/PDEP implementations I believe that significant changes were made. But there was a comment stating that modifying is off topic. As this code is public, then modifications should be ...
Glenn Teitelbaum's user avatar
0 votes
1 answer
249 views

Why was my post closed? Was I too critical of the original author or looking for confirmation bias?

I have a question about my Code Review Stack Exchange post: Is this an appropriate way to use TaskFactory to make asynchronous code synchronous? Which I originally posted on Stack Overflow. My ...
Andrew's user avatar
  • 101
8 votes
2 answers
172 views

Review a piece of code bought from someone else

In How can I speed up this serialized array generation php script? the OP states, that they "bought one [...] script" from someone else. Since I could not identify if the script in question was also ...
AlexV's user avatar
  • 7,250
14 votes
1 answer
163 views

Small portion of reviewable code isn't mine, but credited

I recently asked this question. I looked around, but it doesn't look like my problem has been asked here: A small (9 SLOC) portion of my code is an equation from a user on Stackoverflow. I credit the ...
Linny's user avatar
  • 10.1k
11 votes
3 answers
285 views

"Who Wrote This?" and What Do We Actually Consider Authorship?

As I was working through the Close Votes Review Queue, I came upon a question beginning like this: I just cloned (Github clone, not literal clone) someone's Tic-Tac-Toe game and I was originally ...
Ben Steffan's user avatar
  • 5,228
19 votes
3 answers
218 views

Asking about code in a pull request to my code base

I want to do something that is a little unusual, but not obviously off-topic. As a result, I thought I'd post here first. I got a pull request into a code base I (professionally) maintain. I'd like ...
Conor Mancone's user avatar
8 votes
3 answers
174 views

Is it okay to ask for feedback on code you modified extensively but aren't the original author of?

There's an init script template I used once a while ago. I've been working on tweaking it to be more POSIX compatible and stylistically easier to follow, but I'm not the sole or primary author. https:...
Greg Nisbet's user avatar
11 votes
2 answers
142 views

Posting code that is partially not my own

Say I am learning a programming language through a tutorial. To demonstrate a concept the tutorial provides a program, that is, some working, runnable code (not Code Snippets). Then I encountered an ...
lightning_missile's user avatar
14 votes
1 answer
112 views

Reviews that depend on 3rd party libraries (i.e. code the OP does not own/maintain)

CR has a strict "we only review code you've written or maintain" policy, which is perfectly reasonable, but how should we treat reviews that rely on 3rd party code (i.e. libraries that aren't part of ...
cimmanon's user avatar
  • 3,654
11 votes
2 answers
206 views

Should we do away with "someone else's code" wording?

This has recently been brought up that we should improve this off-topic/close reason. While we can agree that this VTC reason is less than ideal (perhaps too broad, should be two separate reasons) ...
Phrancis's user avatar
  • 20.4k
1 vote
3 answers
166 views

Should we reconsider the code ownership policy?

This question of mine (10k required) was put on hold with the explanation This question does not appear to be a code review request within the scope defined in the help center. Please see the ...
tripleee's user avatar
  • 491
16 votes
5 answers
414 views

Can we revisit "Did I write that code myself"?

Did I write that code myself? This is one of the six questions the help center recommends users should be able to answer "Yes" to before posting their question. I'm not sure I quite understand ...
nhgrif's user avatar
  • 25.3k
13 votes
1 answer
204 views

What does it take to make code your own?

This question is meant as a general question, but it is also specifically about this specific question: https://codereview.stackexchange.com/questions/39228/original-factorial-method-in-java/ It is ...
Simon Forsberg's user avatar
38 votes
2 answers
1k views

Why is only my own written code on-topic?

I tend to disagree with point #2 on the Help Center: Did I write that code? I believe any code, written by one self or anyone else should be eligible for code review. Many a times, you're ...